Rename crisis alert notification contract to email#55
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c9a1fede33
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| strategy_label=strategy_label, | ||
| context_label=context_label, | ||
| alert_namespace="strategy_plugin_google_voice_alert", | ||
| alert_namespace="strategy_plugin_email_alert", |
There was a problem hiding this comment.
Changing alert_namespace to "strategy_plugin_email_alert" causes every alert key to change, because build_strategy_plugin_alert_key includes namespace in both the payload hash and key path. After upgrading, previously recorded markers will no longer match identical signals, so duplicate suppression is lost and already-sent crisis alerts can be sent again until new markers are rebuilt. If this rename is meant to be non-disruptive, keep the old namespace (or perform dual-read compatibility) during migration.
Useful? React with 👍 / 👎.
1 participant
Summary
Tests